Skip to content

Commit

Permalink
Treat WavPack files like MP3
Browse files Browse the repository at this point in the history
Players seem to be able to at least skip ID3v2 or
are even able to display it. ID3v1 should not cause
any trouble at all because its use is even proposed
in the WavPack documentation.
  • Loading branch information
Martchus committed Oct 29, 2017
1 parent c53e5e3 commit cdccc24
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions mediafileinfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -551,8 +551,9 @@ bool MediaFileInfo::createAppropriateTags(bool treatUnknownFilesAsMp3Files, TagU
// creation of ID3 tag is possible
if(!hasAnyTag() && !treatUnknownFilesAsMp3Files) {
switch(containerFormat()) {
case ContainerFormat::MpegAudioFrames:
case ContainerFormat::Adts:
case ContainerFormat::MpegAudioFrames:
case ContainerFormat::WavPack:
break;
default:
return false;
Expand Down Expand Up @@ -588,7 +589,7 @@ bool MediaFileInfo::createAppropriateTags(bool treatUnknownFilesAsMp3Files, TagU
if(mergeMultipleSuccessiveId3v2Tags) {
mergeId3v2Tags();
}
// remove ID3 tags according to id3v2usage and id3v2usage
// remove ID3 tags according to id3v1usage and id3v2usage
if(id3v1usage == TagUsage::Never) {
if(hasId3v1Tag()) {
// transfer tags to ID3v2 tag before removing
Expand Down Expand Up @@ -1139,6 +1140,7 @@ bool MediaFileInfo::areTagsSupported() const
case ContainerFormat::MpegAudioFrames:
case ContainerFormat::Mp4:
case ContainerFormat::Ogg:
case ContainerFormat::WavPack:
case ContainerFormat::Webm:
// these container formats are supported
return true;
Expand Down

0 comments on commit cdccc24

Please sign in to comment.