relax parsing rules to accept openbsd's dhcpd.leases format #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignore 'UTC' suffix on time fields record with missing binding_state defaults to 'active' interpret 'abandoned;' field as 'binding_state abandoned;" added test case for openbsd dhcpd.leases added Makefile for `make test`
2 similar comments
|
Thanks for the PR!, the code looks good but the unit test is broken because you've added a method to the test case with the same name as another method, so most tests don't run currently. |
philwo
reviewed
Jul 7, 2019
| self.binding_state = 'active' | ||
|
|
||
| # support 'abandoned' property for openbsd dhcpd.leases compatibility | ||
| if 'abandonded' in properties: |
|
Hello, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made these changes because I needed this to run on my OpenBSD 6.4 system, which uses a dhcpd that is derived from isc-dhcpd. The dhcpd.leases file has minor differences which required changes to the parser. The existing tests all still pass.
These changes allow the module to read the OpenBSD lease file:
ignore 'UTC' suffix on time fields
record with missing binding_state defaults to 'active'
interpret 'abandoned;' field as 'binding_state abandoned;"
added test case for openbsd dhcpd.leases
added Makefile for
make test