Fix timezone awareness under Python 2.7.x #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The datetime module doesn't provide timezone.utc under Python 2.7.x, so define it for ourselves.
aaron-sierra
force-pushed
the
fix-utc-in-python2
branch
from
6e1ec6a
to
9588128
Compare
|
I'd hate to break it to you... but python 2.7 is EOL |
Don't feel bad about saving me work, unless you mean that you've officially dropped Python 2.7 support in this module. Builds are still happening against Python 2.7 and the README still has instructions for installing for it, too. I didn't want to be the reason that Python 2.7 stopped being supported. |
|
Well the change to keep 2.7 supported in this module seems relatively minor. It's probably a good idea to keep support around for that since this code is already written now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the build is failing under Python 2.7.x as a result of the changes I introduced in #32...