Lease6 iaid duid properties #4
Conversation
| @@ -160,6 +162,9 @@ def __init__(self, ip, data, cltt, host_identifier, address_type): | |||
| self.last_communication = cltt | |||
|
|
|||
| self.host_identifier = codecs.decode(host_identifier, "unicode_escape") | |||
| host_identifier_bytes = self.host_identifier.encode('latin-1') | |||
| self.iaid = int.from_bytes(host_identifier_bytes[0:4], byteorder='little') | |||
There was a problem hiding this comment.
This breaks compatibility with python 2.7 since this function is python 3 specific.
There was a problem hiding this comment.
should be fixed now
freddy36
force-pushed
the
lease6_iaid_duid_properties
branch
from
019240f
to
81ae7c3
Compare
|
This is a great functionallity to have but there is no test case added. I also added some comments in the code |
freddy36
force-pushed
the
lease6_iaid_duid_properties
branch
from
81ae7c3
to
cdb03a2
Compare
|
python 2.7 compatibility has been restored and test cases have been updated |
|
The python2.7 tests are still failing. It seems my travis config is not fully correct since it reports the status of the coveralls upload but if you look at https://travis-ci.org/MartijnBraam/python-isc-dhcp-leases/jobs/79677899 you can see the errors. These are all unicode but i'm not completely sure how to fix that without breaking python3.2 compatability Also from the dhcpd.leases documentation:
The quoted variant used in the dhcpd6.leases test file are in octal and parsed as a escaped unicode string so the value is correct. Also the code doesn't account for the colon-separated variant but that's a problem for when I actually have a example file to test against |
add iaid and duid properties to the Lease6 object (extracted from the host_identifier)