fix routing for SS 3.2+

[xini]

Hi @Martimiz,
I have been struggling to setup the routing for this module using SS 3.4.
I followed your instructions on https://github.com/Martimiz/silverstripe-languageprefix/blob/master/docs/en/routing.md, but it just didn't quite work. I then updated all the core routes from cms and framework and it seems to work.
Initially I had put the consolidated routes in mysite/_config/routes.yml, but then I thought it might be worthwhile to directly incorporate them in the module itself. Hence this PR.
What was your intention by having the routing in the instructions and not already setup in the code? SS version issues and maintainability, I assume?
Is there a way we can make this more flexible without re-defining all the core routes? And without having to setup the routing for each project manually (again)?
Cheers, Flo

[Martimiz]

Thanks for your effort, xini!

To be totally honest, I actually forgot about this fix, that should only have been temporary in the first place... So before implementing your pull, which is basically making the temp solution final, I'd like to look into this one more time.

I'll get back to you :)

Martine

[xini]

No worries. Yes, I suspected something like that. Thanks!

[Martimiz]

OK, sorry for never getting back to this - that shouldn't have happened!

This used to be an issue in early versions of SilverStripe 3, but I'm sure it isn't anymore in current versions, so v3.0.0 should work fine now, without that patch. Let me know if I'm still misscing something...

[xini]

Hey, no worries. I can't even recall what project I used this for. But my pull request was done after you released 3.0.0 and it's called "fix routing for SS 3.2+", which means that there was an issue with newer versions of SS.

[Martimiz]

I know the problem existed and I'm quite sure it's actually a framework issue. I remeber in early 2.0 I had somerhing similar implemented - there is still the docs/en/routing.md that explains. It was removed after I was told the problem no longer existed and oI tested it on a couple of sites and versions

I'll close this one for now. Please let me know if you ever run into that problem again, so we can find out what actually causes it. Thanks again

[edit] in v2.0.0 and v3.0.0 one explanation/solution still lives in docs/en/routing.md...