Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update library according actual best practices #18

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

thekip
Copy link
Contributor

@thekip thekip commented Mar 22, 2023

  1. Building migrated to unbuild this stuff automatically discover entries in package.json and build cjs / esm / tsd target as well as checking common issues.
  2. bin field added. cli also rewritten to typescript and included in building.
  3. exports field added. It means lib explicitly states only allowed exports!
  4. jest, typescript, eslint - updated
  5. folder with generated artifacts deleted.
  6. NodeJs bumped to v16. v14 has EOL in 1 month. Bumping version of nodejs requiring bumping a major version of package, so instead of two major releases in row in a short time, let's start from node16 right now.
  7. GitHub Workflow for CI added. @MartinCerny-awin you need to add a codecov application to this repository, please read this guide the rest of the setup is already made.

Next steps - we need to resolve questions asked in #17 and i can continue working on setting up automatic releases with tags and changelogs in github.

@thekip thekip marked this pull request as draft March 22, 2023 10:27
@thekip thekip marked this pull request as ready for review March 22, 2023 10:43
@MartinCerny-awin MartinCerny-awin merged commit f5ea163 into MartinCerny-awin:main Apr 4, 2023
@thekip thekip deleted the update-lib branch April 4, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants