Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET v4.0 compatibility #7

Closed
devatwork opened this issue Jul 26, 2012 · 3 comments · Fixed by #8
Closed

.NET v4.0 compatibility #7

devatwork opened this issue Jul 26, 2012 · 3 comments · Fixed by #8

Comments

@devatwork
Copy link
Contributor

Hello Martin,

In version 3 of Dynamo you switched from .NET v4.0 to v4.5 as your target framework. My current codebase is running on v4.0.

When I upgraded to 3.0.0.1 I got the following error:
Could not load type 'System.Runtime.CompilerServices.ExtensionAttribute' from assembly 'mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089'.

This error is caused by the fact that the ExtensionAttribute is moved from the System.Core to mscorlib assembly. See http://stackoverflow.com/a/11265032.

I have forked this project and changed the target framework back to v4.0, compiled it and include that assembly in my project, which fixed the problem for me.

So I was wondering if you plan to use v4.5 specific APIs? If not, we could add new projects targeting the v4.0 specifically. Via NuGet we can distribute runtime specific versions, see http://docs.nuget.org/docs/creating-packages/creating-and-publishing-a-package#Framework_Names.

Regards,
Bert

@MartinF
Copy link
Owner

MartinF commented Jul 28, 2012

Hello Bert,

For now there is actually no reason for using v4.5.

Your suggestion seems like a very good idea, ill just need to try to find the time to make it happen :)

Best regards

Martin

-----Oprindelig meddelelse-----
Fra: Bert Willems [mailto:reply@reply.github.com]
Sendt: 26. juli 2012 09:21
Til: Martin From
Emne: [DynamoIOC] .NET v4.0 compatibility (#7)

Hello Martin,

In version 3 of Dynamo you switched from .NET v4.0 to v4.5 as your target framework. My current codebase is running on v4.0.

When I upgraded to 3.0.0.1 I got the following error:
Could not load type 'System.Runtime.CompilerServices.ExtensionAttribute' from assembly 'mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089'.

This error is caused by the fact that the ExtensionAttribute is moved from the System.Core to mscorlib assembly. See http://stackoverflow.com/a/11265032.

I have forked this project and changed the target framework back to v4.0, compiled it and include that assembly in my project, which fixed the problem for me.

So I was wondering if you plan to use v4.5 specific APIs? If not, we could add new projects targeting the v4.0 specifically. Via NuGet we can distribute runtime specific versions, see http://docs.nuget.org/docs/creating-packages/creating-and-publishing-a-package#Framework_Names.

Regards,
Bert


Reply to this email directly or view it on GitHub:
#7

@devatwork
Copy link
Contributor Author

hallo Martin,

i can send you a pull-request today or tomorrow.

regards,
bert

@devatwork
Copy link
Contributor Author

Pull request has been send, this issue is duplicate now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants