Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement finding location in target and query where best score was found #13

Closed
Martinsos opened this issue Dec 27, 2014 · 1 comment
Closed

Implement finding location in target and query where best score was found #13

Martinsos opened this issue Dec 27, 2014 · 1 comment
Labels
enhancement high priority
Milestone
1.0.0

Comments

@Martinsos
Copy link
Owner

This is first step in implementing finding of alignment (#1). I want this to affect speed of calculation as little as possible, which is the biggest challenge.
@Martinsos Martinsos added this to the 1.0.0 milestone Dec 27, 2014
Martinsos added a commit that referenced this issue Dec 28, 2014
@Martinsos
Issue #13: Added storing of some data to track the row.
b4bee66
Martinsos added a commit that referenced this issue Dec 29, 2014
@Martinsos
Issue #13: Basic functionality for finding last position added
789b339
Martinsos added a commit that referenced this issue Dec 29, 2014
@Martinsos
Issue #13: now actually works
1096801
Martinsos added a commit that referenced this issue Dec 29, 2014
@Martinsos
Issue #13: small improvement in speed
6eb086f
Martinsos added a commit that referenced this issue Dec 30, 2014
@Martinsos
Issue #13: small enhancments
9707882
Martinsos added a commit that referenced this issue Dec 31, 2014
@Martinsos
Issue #13: Added end location for HV and NW, OV not yet.
6c4f786
Martinsos added a commit that referenced this issue Dec 31, 2014
@Martinsos
Issue #13: added end location for OV, should test all
8f12276
Martinsos added a commit that referenced this issue Jan 6, 2015
@Martinsos
Issue #13: Wrote tests, all passing
860e81d
Martinsos added a commit that referenced this issue Jan 6, 2015
@Martinsos
Issue #13: Added finding of end location of alignment.
a465880
Martinsos added a commit that referenced this issue Jan 6, 2015
@Martinsos
Issue #13: Added finding of end location of alignment.
c6b7ad3 
Also changed function definition: now result structure is used to return result.
@Martinsos
Copy link
Owner Author

Finished!
All works fine, it made the whole code slower for about 20%, but I will deal with that later, maybe by putting a flag to turn of the finding of last position, if that will help.
Integrated with c6b7ad3.

@Martinsos Martinsos mentioned this issue Jan 6, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement high priority
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@Martinsos