Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember scroll position in Cortex Peripheral panels #370

Closed
timblakely opened this issue Dec 17, 2020 · 8 comments
Closed

Remember scroll position in Cortex Peripheral panels #370

timblakely opened this issue Dec 17, 2020 · 8 comments

Comments

@timblakely
Copy link

Hopefully this is an easy one for ya :) Love that the Peripherals panel remembers which peripherals/registers are expanded, but it seems whenever I restart debugging the panel's scroll is reset back to the top (possibly after re-parsing the SVD?). This makes debugging peripherals towards the end of the alphabet like TIMx, WWDG, etc a bit of a chore since it requires re-scrolling down the peripherals panel to find it again. It would be ideal if the panel could remember the last scrolled position and reposition itself there upon next debugging session.

@Marus
Copy link
Owner

Marus commented Jan 18, 2021

Unfortunately, while this would be very nice, I don't think this will with the current extension APIs that I have for visual studio code - it is something I will look into though.

@manuargue
Copy link
Contributor

@timblakely As a workaround for avoiding scrolling down to the bottom, you can focus on the peripheral view and start typing the peripheral name for searching it.

Probably it would be nice to have some sort of "pinning" button on each peripheral so that it can be brought to the top until unpinned.

@manuargue
Copy link
Contributor

@Marus I could add a "pin" button on each peripheral node so that it stick to the top of the peripheral list. This state can be persisted. It's handy when debugging the same peripheral frequently. What do you think? I can work on this.

@Marus
Copy link
Owner

Marus commented Jan 21, 2021

@manuargue - Pin/Unpin at the peripheral layer, which would just sort those ones to the top, I think is a great idea, and I think would help a lot with what @timblakely actually wants to accomplish. Shouldn't be too hard to actually achieve either I don't believe.

If you want to take a stab at this I'd be happy to look at it when ready and include it in the releases.

@timblakely
Copy link
Author

Absolutely, the ability to pin a device to the top of the list would solve it completely, and likely be even more useful when working in situations involving multiple subsystems (DMA, interrupts, etc)!

@manuargue
Copy link
Contributor

Great, I'll work on this and try to have the pr opened by this weekend.

manuargue pushed a commit to manuargue/cortex-debug that referenced this issue Jan 21, 2021
It allows to pin a peripheral node to the top of the list
for quicker access. Useful when debugging some peripheral
to avoid scrolling or searching it everytime the debug
session is restarted. The state is persisted across
debugging sessions.

Signed-off-by: Manuel Argüelles <manu.argue@gmail.com>
manuargue pushed a commit to manuargue/cortex-debug that referenced this issue Jan 22, 2021
Signed-off-by: Manuel Argüelles <manu.argue@gmail.com>
Marus added a commit that referenced this issue Jan 22, 2021
issue #370: add toggle pin button to peripherals
@timblakely
Copy link
Author

Works like a charm, thank ya much! Unless you've got additional work to do, feel free to close this bug.

@Marus
Copy link
Owner

Marus commented Jan 26, 2021

Closing this since the alternative of pinning was released. Thanks again for the PR @manuargue

@Marus Marus closed this as completed Jan 26, 2021
mayjs pushed a commit to mayjs/cortex-debug that referenced this issue Apr 6, 2022
It allows to pin a peripheral node to the top of the list
for quicker access. Useful when debugging some peripheral
to avoid scrolling or searching it everytime the debug
session is restarted. The state is persisted across
debugging sessions.

Signed-off-by: Manuel Argüelles <manu.argue@gmail.com>
mayjs pushed a commit to mayjs/cortex-debug that referenced this issue Apr 6, 2022
Signed-off-by: Manuel Argüelles <manu.argue@gmail.com>
mayjs pushed a commit to mayjs/cortex-debug that referenced this issue Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants