Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: use stable key ordering for snapshots with maps #190

Merged
merged 1 commit into from
Nov 22, 2022
Merged

fix!: use stable key ordering for snapshots with maps #190

merged 1 commit into from
Nov 22, 2022

Commits on Nov 21, 2022

  1. fix: use stable key ordering for snapshots with maps 

    Snapshots containing maps are unstable because iteration order of a map's
keys is not guaranteed.

The spew library can sort map keys that are sortable to provide
stability at the cost of speed. Some types are not sortable, and there
is a spew option to deal with this.

This option first serializes keys to strings using spew, then sorts.
This behaviour should probably be opt-in, so it's not included here.
    @jamestelfer
    jamestelfer committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    7496539 View commit details
    Browse the repository at this point in the history