Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes and general improvements #1

Merged
merged 9 commits into from
Sep 20, 2022
Merged

Bug fixes and general improvements #1

merged 9 commits into from
Sep 20, 2022

Conversation

MarwanAlsoltany
Copy link
Owner

@MarwanAlsoltany MarwanAlsoltany commented Sep 20, 2022

Pull Request Template

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

Motivation and Context

Why is this change required? What problem does it solve?

If it fixes an open issue, please link to the issue here (if you write Fixes #number
or Closes #number, the issue will be automatically closed when the pull is accepted).

Types of Changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).
  • This change requires a documentation update.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Screenshots (if appropriate)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • I have created a branch for this patch/feature.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made sure that my code follows the style guidelines of this project.
  • I have added tests to cover my changes that prove my fix is effective or that my feature works.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask.

* Update class constructor to check for nested attributes types
* Add rule name as a second parameter for message translation callback
* Fix some typos
* Add presedence for null safe operator
* Add presedence for null safe operator
@codecov-commenter
Copy link

Codecov Report

Base: 99.96% // Head: 99.96% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (78aea98) compared to base (ae246f1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage     99.96%   99.96%           
- Complexity      367      370    +3     
=========================================
  Files            43       43           
  Lines          3230     3234    +4     
=========================================
+ Hits           3229     3233    +4     
  Misses            1        1           
Flag Coverage Δ
unittests 99.96% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Rule.php 100.00% <100.00%> (ø)
src/Validation/Constraint/Shape.php 100.00% <100.00%> (ø)
src/Validation/Logic/rules/condition.php 100.00% <100.00%> (ø)
src/Validation/Logic/rules/filter.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MarwanAlsoltany MarwanAlsoltany merged commit 2575427 into master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants