New features, bug fixes, and general improvements #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix messages placeholders
* Fix messages placeholders
* Fix messages placeholders
* Add `6.4.0 Comments` section
* Update build() method checks for expression validity
* Add conct() method * Update write() method * Add comment() method * Update variable() method * Update class DocBlock
* Update evaluateBitwiseExpression() method checks for expression validity
* Update parseExpression() method to allow for same rule repeation
* Add cleanExpression() method * Add evaluateExpression() method * Update class DocBlock
* Update transform() method to alywas use UTF-8 * Update some DocBlocks
* Refactor validateOne() method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here (if you write
Fixes #numberor
Closes #number, the issue will be automatically closed when the pull is accepted).Types of Changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Screenshots (if appropriate)
Checklist:
Go over all the following points, and put an
xin all the boxes that apply.Please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.
If you're unsure about any of these, don't hesitate to ask.