Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General improvements and PHP 8.2 support #4

Merged
merged 22 commits into from
Dec 9, 2022
Merged

General improvements and PHP 8.2 support #4

merged 22 commits into from
Dec 9, 2022

Conversation

MarwanAlsoltany
Copy link
Owner

Pull Request Template

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

Motivation and Context

Why is this change required? What problem does it solve?

If it fixes an open issue, please link to the issue here (if you write Fixes #number
or Closes #number, the issue will be automatically closed when the pull is accepted).

Types of Changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).
  • This change requires a documentation update.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Screenshots (if appropriate)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • I have created a branch for this patch/feature.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made sure that my code follows the style guidelines of this project.
  • I have added tests to cover my changes that prove my fix is effective or that my feature works.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask.

* Rename method groupConstraints() to combineConstraints()
* Fix some DocBlocks
* Rename property $recursive to $traverse
* Fix some DocBlocks
* Add missing use statement
* Add $validator property
* Rename getValidator() method to getMasterValidator()
* Add getValidator() method
* Add setValidator() method
* Update validate() method
* Update class constructor to use master validator to check parameters
* Update class constructor to use master validator to check parameters
* Update validate() method to use object's validator
* Update class constructor to use master validator to check parameters
* Update validate() method to use object's validator
* Update validate() method to use object's validator
* Move Maker class from MAKS\Mighty\Validation to MAKS\Mighty namespace
* Update Maker namespace
* Update Maker namespace
* Update Maker namespace
* Regenerate src/Validation/Constraints/Rule/*
* Update 'string.charset' rule to fix an issue with PHP 8.2
* Fix typos in test methods names
* Update deprecated configuration values
* Add PHP 8.2 support
* Add PHP 8.2 support
* Update branch-alias
@MarwanAlsoltany MarwanAlsoltany merged commit 750c153 into master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant