Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As was pointed out to me by @m4rw3r
&[T]
streams are usually on&[u8]
or other typesT
which are copyable. This would allow the Item type of such streams to beT
rather than&T
but has the downside that you can use&[T]
whereT != Copy
. A newtype could be added which wraps such&[T]
slices allowing for&T
items again.Alternatives:
I don't have much of any opinion either way but it needs to be decided before 1.0. Wrapping the slice in a newtype is only necessary for the first call to parse so its only a minor ergonomic win for the case which does not need wrapping, it's more of deciding which way is the least surprising for the majority of users.