Problems with ShapeCircle Segmented Bar

[zvonicek]

I'm having some issues with ShapeCircle Segmented Bar when creating it programmatically. ShapeRectangle and ShapeRoundedRect works fine, but when I change the type to ShapeCircle, segmented bar is not displayed at all.

I suppose it has something to do with calculating cornerRadius in drawIndeterminate method as if I replace line 439 in M13ProgressViewSegmentedBar.m with cornerRadius = _cornerRadius, it solves the issue. However, I'm not sure about the consequences of that.

[Marxon13]

Could you link an example. Line 439 is the way it is to make sure that the corner radius is always a circle, by going off the minimum of the width or height.

[zvonicek]

Sure, this is the example:

M13ProgressViewSegmentedBar* progressBar = [[M13ProgressViewSegmentedBar alloc] initWithFrame:CGRectMake(10.0, 0.0, 100.0, 20.0)]
progressBar.progressDirection = M13ProgressViewSegmentedBarProgressDirectionLeftToRight;
progressBar.indeterminate = YES;
progressBar.segmentShape = M13ProgressViewSegmentedBarSegmentShapeCircle;

[self.view addSubview:progressBar];

Anyway, I went little bit deeper and found out that the problem was the origin.y coordinate set to 0.0. Segmented Bar is actually placed few pixels above it's y coordinate and therefore in this case it was not visible.
Perhaps it could be improved to respect the y coordinate more accurately.

[Marxon13]

I'm not sure what is going on. The only frame setting for the segmented bar is done in initWithFrame:. The only time the subview frames are changed is in layoutSubviews, and their frames are set to the segmented bar's bounds.

Could you link a full project?

[zvonicek]

I've commited a sample here: https://github.com/zvonicek/M13ProgressSuite/tree/segmentedBarBug. When you run the app and select the "Segmented Bar" TableView row, there is the new yellow view there. This view has two subviews – two Segmented Bars. Their frame differ only in origin.x coordinate, but the Circle one is apparently upper than the Rectangle one (and actually above the yellow view).

As I said, replacing the line (currently 443) seems to solve it – place the Circle Segmented Bar in a correct position, but I'm not sure about the side effects.