Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final code for v3.0.0 release #96

Merged
merged 22 commits into from
Nov 17, 2017
Merged

Final code for v3.0.0 release #96

merged 22 commits into from
Nov 17, 2017

Conversation

Marzogh
Copy link
Owner

@Marzogh Marzogh commented Nov 10, 2017

No description provided.

Marzogh and others added 10 commits August 19, 2017 01:17
Pull in the latest stable code from the development branch
Confirmed to work with SPANSION/CYPRESS & MICROCHIP (Both SST25 & SST…
Pull final code changes for v3.0.0
…pment

Merge all changes from work done over weekend.
Update the branch to the latest code from Github
…ng when using flash memory larger than 128 MB

--> 4-byte addressing enabled in flash memory larger than 128 MB. This is currently only supported on the W25Q256 and W25Q512. More chips will be supported on a case-by-case basis
--> Fixed bug where the capacity of the W25Q128 was wrongly recognised as 6 MB
size_t gets exceeded for larger flash chips (e.g. 16 MBit) on Atmega 1284P
@Marzogh Marzogh added bugfix Fixes an existing bug in the current version of the code duplicate This issue is a duplicate of another issue (more info in comments) enhancement An enhancement to the library's function is proposed labels Nov 10, 2017
@Marzogh Marzogh added this to the 3.0.0 milestone Nov 10, 2017
@Marzogh Marzogh self-assigned this Nov 10, 2017
@Marzogh
Copy link
Owner Author

Marzogh commented Nov 10, 2017

@thedub2001, This is the final code ('stable' branch) going into v3.0.0 could you check to see if it works with the W25Q256? Thanks!

@boseji, Can you please confirm that v3.0.0 code from the 'stable' branch works with the RTL8195A? Once you confirm that, I can go ahead and make RTL8195A support official. 😃 If you want to add support for any new boards please do so on the 'development' branch and I'll roll that into the next release.

@boseji
Copy link
Contributor

boseji commented Nov 10, 2017

Sure will check this out tonight and confirm.

@Marzogh
Copy link
Owner Author

Marzogh commented Nov 10, 2017

Thanks!

@boseji
Copy link
Contributor

boseji commented Nov 10, 2017

I have just checked out the Development Branch against RTL8195 with W25Q128FV there are some problems.

  • FlashDiagnostics completely crahes
  • TestFlash is not able to write to Flash properly. Both Page and Word write fail.

Not yet sure whats wrong. These are my iniital findings on the RTL8195.
Need to look into this in detail.

@Marzogh
Copy link
Owner Author

Marzogh commented Nov 10, 2017

Hmmm... I'll hold off on the release till the end of next week to give you time. Please let me know if you need more time. 🙂

@boseji
Copy link
Contributor

boseji commented Nov 13, 2017

It look like some thing is broken from the SDK side I mean the release 2.0.2 of the tool-chain .
The access to SPI settings is causing a hard fault situation in RTL8195.

I would recommend that we drop official support for RTL8195 as of v3.0.0
So that there is no delay in release.

In the mean time I would work on the development branch to see what exactly went wrong.
Then in the next release if my development side is fixed with RTL8195 specific changes.
We can merge official support for RTL8195 again.

Please take this forward.

@thedub2001
Copy link

thedub2001 commented Nov 13, 2017

Hello !
I haves tested the "stable" branch with W25Q256.
I used the "FlashDiagnostics" sketch.
Everything is OK, here is the serial output :

Initialising Flash memory..........
Chip Diagnostics initiated.

No Chip size defined by user



--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
                                                                    SPIFlash Library version: 3.0.0
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
                                                                                Get ID
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
			JEDEC ID: ef4019h
			Manufacturer ID: efh
			Memory Type: 40h
			Capacity: 33554432 bytes
			Maximum pages: 131072
			Unique ID: 2200514064491264, 64A4A75B1B232300
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

			Erase Chip: 		Data I/O test PASS			Time: 72.351 s
			Erase 64KB Block: 	Data I/O test PASS			Time: 240 us
			Erase 32KB Block: 	Data I/O test PASS			Time: 280 us
			Erase 4KB Sector: 	Data I/O test PASS			Time: 272 us

			Byte: 			Data I/O test PASS			Write Time: 336 us,	Read Time: 136 us
			Char: 			Data I/O test PASS			Write Time: 328 us,	Read Time: 120 us
			Word: 			Data I/O test PASS			Write Time: 352 us,	Read Time: 128 us
			Short: 			Data I/O test PASS			Write Time: 360 us,	Read Time: 128 us
			ULong: 			Data I/O test PASS			Write Time: 384 us,	Read Time: 144 us
			Long: 			Data I/O test PASS			Write Time: 384 us,	Read Time: 144 us
			Float: 			Data I/O test PASS			Write Time: 376 us,	Read Time: 136 us
			Struct: 		Data I/O test PASS			Write Time: 136 us,	Read Time: 136 us
			Byte Array: 		Data I/O test PASS			Write Time: 5.112 ms,	Read Time: 848 us
			String: 		Data I/O test PASS			Write Time: 424 us,	Read Time: 152 us
			Power Down: 		Data I/O test PASS			Time: 160 us
			Power Up: 		Data I/O test PASS			Time: 136 us
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Great work! 😀

@Marzogh
Copy link
Owner Author

Marzogh commented Nov 15, 2017

Thanks guys. I'll finish up with updating the API docs / wiki and then get the release out of the door this weekend. 🙂

@Marzogh Marzogh removed the duplicate This issue is a duplicate of another issue (more info in comments) label Nov 17, 2017
@Marzogh Marzogh merged commit 4347aee into master Nov 17, 2017
@boseji
Copy link
Contributor

boseji commented Nov 20, 2017

I have been trying to get the flash to work with RTL8195.
It looks like some dip in power to Flash chip during the Flash Diagnostics .
That was causing issues with flash testing.
I will try get a new board for the W25Q128FV with RTL8195.
Also will try to check the v2.7.0 one more time, since the Flash interface was working at that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes an existing bug in the current version of the code enhancement An enhancement to the library's function is proposed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants