Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/support top right + bottom right bubble directions #25

Conversation

luongvo
Copy link
Contributor

@luongvo luongvo commented Jul 23, 2020

What happened 🤔

We use this lib but it doesn't support TOP-RIGHT or BOTTOM-RIGHT direction so we decided to add support to solve this issue #18.

PoW (a.k.a Proof Of Work)💪

Solve #18

20200724_005208

@luongvo luongvo force-pushed the feature/support-top-right-bubble-direction branch from f2eb302 to fd67610 Compare July 23, 2020 17:53
@luongvo luongvo changed the title Feature/support top right bubble direction Feature/support top right + bottom right bubble directions Jul 23, 2020
@MasayukiSuda MasayukiSuda self-requested a review July 27, 2020 01:09
Copy link
Owner

@MasayukiSuda MasayukiSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MasayukiSuda MasayukiSuda merged commit b5f709e into MasayukiSuda:master Jul 27, 2020
@MasayukiSuda
Copy link
Owner

Thanks great pull request !!!

@luongvo luongvo deleted the feature/support-top-right-bubble-direction branch July 30, 2020 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants