Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing logger through constructor #63

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

CharlieChristensen
Copy link

If an error occurs while creating a DataSource, the logger is null and causes a crash. This allows you to pass a logger into the constructor, otherwise use the default logger.

@MasayukiSuda MasayukiSuda merged commit 94c76e2 into MasayukiSuda:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants