Adding "total" in API responses + database stats in "/status" endpoint #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subnetmarco
force-pushed
the
chore/api-totals
branch
from
4b3122b
to
21d77a5
Compare
subnetmarco
added a commit
that referenced
this pull request
Oct 16, 2015
Adding "total" in API responses + database stats in "/status" endpoint
|
The correct namespace for this is 'feat'. Also would have appreciate a review before merging |
| @@ -553,9 +553,12 @@ end | |||
| -- @return `res` | |||
| -- @return `err` | |||
| -- @return `filtering` A boolean indicating if ALLOW FILTERING was needed by the query | |||
| function BaseDao:count_by_keys(where_t) | |||
| function BaseDao:count_by_keys(where_t, page_size, paging_state) | |||
| local select_q, where_columns, filtering = query_builder.count(self._table, where_t, self._column_family_details) | |||
There was a problem hiding this comment.
Oh you mean instead of select_q - the PR that introduced the count function has been waiting for a while under the dao/count branch, so I merged it. Didn't spot this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements:
totalfield in each API response, that counts the total number of elements in the table regardless of thesizeandoffsetspecified.nextlink if there are no morenextelements to show./statusendpoint, and moves the old stats into aserverparent key, like:{ "server": { "connections_handled": 1, "connections_reading": 0, "connections_active": 1, "connections_waiting": 0, "connections_writing": 1, "total_requests": 3, "connections_accepted": 1 }, "database": { "oauth2_tokens": 1, "jwt_secrets": 0, "response_ratelimiting_metrics": 0, "keyauth_credentials": 0, "oauth2_authorization_codes": 0, "acls": 0, "apis": 2, "hmacauth_credentials": 0, "consumers": 1, "plugins": 1, "oauth2_credentials": 1, "basicauth_credentials": 0, "ratelimiting_metrics": 0 } }