Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace globals with kong.singletons module variables. #981

Closed

Conversation

mars
Copy link
Contributor

@mars mars commented Feb 11, 2016

Follow-through from mars@f59c849

Replacing globals will not change any functional behavior. It will:

  • avoid slow global lookups
  • make it easier for devs to see where values come from

The module name singletons was chosen to make it easy to find these anywhere in the project; names like env, environment, config, etc. would lead to confusion.

@mars
Copy link
Contributor Author

mars commented Feb 11, 2016

Closing because this code was not cleanly cherry-picked. My local lua env is f*cked and this is broken :(

@mars mars closed this Feb 11, 2016
@mars mars deleted the feature/convert-globals-to-module-vars branch February 11, 2016 00:18
@mars mars restored the feature/convert-globals-to-module-vars branch February 11, 2016 00:20
@mars mars deleted the feature/convert-globals-to-module-vars branch February 11, 2016 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant