Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move directWrite outside the loop #498

Merged

Conversation

esspe2
Copy link
Contributor

@esspe2 esspe2 commented May 7, 2019

No need to repeat 1000 times the same actions, it seems sufficient to do the directWrite only once before the loop instead.

No need to repeat 1000 times the same actions, it seems sufficient to do the directWrite once before the loop instead.
@MaslowCommunityGardenRobot
Copy link
Collaborator

Congratulations on the pull request @esspe2

Now we need to decide as a community if we want to integrate these changes. You should vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 48 hours. Ties will not be merged.

I'm just a robot, but I love to see people contributing so I'm going vote thumbs up (but my vote won't count...)!

Copy link
Collaborator

@blurfl blurfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this and it works as expected. Makes sense to send only once, since the motor speed is not altered during the test.

@blurfl
Copy link
Collaborator

blurfl commented May 8, 2019

Glad to see you combing through the code @esspe2! Keep up the good work! 💯👍

@esspe2
Copy link
Contributor Author

esspe2 commented May 9, 2019

Thanks for your good words!

The call chain to the eeprom write is more like this:

 maslowDelay() 
 -> execSystemRealtime() 
 -> systemSaveAxesPosition() 
 -> settingsSaveStepstoEEprom() 
 -> EEPROM.put(310, sysSteps)

so this change doesn't really improve the eeprom issue, but I still feel it useful.

@MaslowCommunityGardenRobot
Copy link
Collaborator

Time is up and we're ready to merge this pull request. Great work!

@MaslowCommunityGardenRobot MaslowCommunityGardenRobot merged commit b01abd2 into MaslowCNC:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants