Merge Holey Calibration Updates into MaslowCNC:master #518
Conversation
This version was verified against the GC kinematics implementation. Afterward, the multiple print commands were deleted, and unneeded calculations were removed.
In the previous implementation, a positive chain tolerance made the effective chain length shorter, which is the opposite of the intent. The new implementation inverts that, so a positive chain tolerance results in a longer chain length.
Merging updates into fork
Merging MaslowCNC/Firmware into schmittjoshc/Firmware. Merging conflict in Kinematics.cpp
Merging MaslowCNC/Firmware into schmittjoshc/Firmware
Merging MaslowCNC:main into schmittjoshc/Firmware main fork
|
While this is a development that is much anticipated, maybe a PR that makes so many changes should wait until after the pending release. That would separate these changes from others and make testing and rollback easier. |
|
Congratulations on the pull request @schmittjoshc Now we need to decide as a community if we want to integrate these changes. You should vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 48 hours. Ties will not be merged. I'm just a robot, but I love to see people contributing so I'm going vote thumbs up (but my vote won't count...)! |
|
Does this incorporate all the changes in the holey calibration branch? If so I think this is a good motivator for us to get the release done quickly and then merge these changes for extensive testing in the next release. |
|
It looks like adding these changes right now isn't a good idea. Consider any feedback that the community has given about why not and feel free to open a new pull request with the changes |
This is a pull request to merge all updates from schmittjoshc/Firmware:master into MaslowCNC/Firmware:master.