Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move choose chain over sprocket direction to after measuring distance between motors #671

Conversation

BarbourSmith
Copy link
Member

As mentioned in this forum thread asking for the chain over the sprocket direction before measuring the distance between the motors is setting folks up to be confused because measuring the distance between the motors may use the chains in a different way.

Should we move asking the kinematics type and the guess for the vertical distance to the motors down too just to keep them together?

@blurfl
Copy link
Collaborator

blurfl commented Mar 26, 2018

guess for the vertical distance to the motors

Is that really necessary? Could we use the current value if it is present, or at least show what it is/was? I keep having to go look it up when running tests 😁

@BarbourSmith
Copy link
Member Author

If you skip it it will use the current value. I think it's important to have a chance to enter something because the calibration process will dial it in, but we have to be in the ball park

@BarbourSmith
Copy link
Member Author

We could auto populate with the current value, that way you wouldn't have to look it up!

@blurfl
Copy link
Collaborator

blurfl commented Mar 26, 2018

If you skip it it will use the current value.

If I click 'Next' without entering a number I bump my nose... "Couldn't convert that to a number..."

@blurfl
Copy link
Collaborator

blurfl commented Mar 26, 2018

Moving the top/bottom choice does what is wanted, and removing the middle picture helps focus the eye on the chain placement. 👍💯

@BarbourSmith BarbourSmith merged commit dbb3cca into master Apr 2, 2018
@BarbourSmith BarbourSmith deleted the move-measure-distance-before-asking-about-chain-direction branch April 2, 2018 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants