Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to setting plunge depth of Zaxis touch probe. #770

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

CptanPanic
Copy link
Contributor

@CptanPanic CptanPanic commented Sep 3, 2018

  1. Enabled touch zero button
  2. Made default plunge depth max of 0 to prevent problems if pressed and you don't have touch plate setup.
  3. Added advanced option to allow modifying to max plunge depth. Personally I use it at 20mm to be able to retract change bit, and just press touch.

I have tested this on my machine.

@BarbourSmith
Copy link
Member

Made default plunge depth max of 0 to prevent problems if pressed and you don't have touch plate setup.

This is such a great idea. Well done. 👍 👍 🎉

I'll give the code a look over right away, although I can't test it because I don't have a touch plate set up 🙄

@MaslowCommunityGardenRobot
Copy link
Collaborator

Congratulations on the pull request @CptanPanic

Now we need to decide as a community if we want to integrate these changes. Vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 48 hours. Ties will not be merged.

I'm just a robot, but I love to see people contributing so I'm going vote thumbs up!

@MaslowCommunityGardenRobot
Copy link
Collaborator

Time is up and we're ready to merge this pull request. Great work!

@MaslowCommunityGardenRobot MaslowCommunityGardenRobot merged commit a42d628 into MaslowCNC:master Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants