Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pillow to requirements_osx.txt and requirements_linux.txt #773

Conversation

johnboiles
Copy link
Contributor

@johnboiles johnboiles commented Sep 21, 2018

When I first tried to run GroundControl from source, I got an ImportError: No module named PIL.

> brew install cython
> virtualenv -p python 2.7 venv
> source venv/bin/activate
> pip install cython # don't understand this, but was necessary
> pip install -r requirements_osx.txt
> python main.py
[INFO              ] [Logger      ] Record log in /Users/johnboiles/.kivy/logs/kivy_18-09-20_5.txt
[INFO              ] [Kivy        ] v1.9.1
[INFO              ] [Python      ] v2.7.10 (default, Oct  6 2017, 22:29:07)
[GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.31)]
[INFO              ] [Factory     ] 179 symbols loaded
[INFO              ] [Image       ] Providers: img_tex, img_imageio, img_dds, img_gif, img_pygame (img_pil, img_ffpyplayer ignored)
[INFO              ] [Window      ] Provider: pygame
[INFO              ] [GL          ] OpenGL version <2.1 ATI-1.68.20>
[INFO              ] [GL          ] OpenGL vendor <ATI Technologies Inc.>
[INFO              ] [GL          ] OpenGL renderer <AMD Radeon R9 M370X OpenGL Engine>
[INFO              ] [GL          ] OpenGL parsed version: 2, 1
[INFO              ] [GL          ] Shading version <1.20>
[INFO              ] [GL          ] Texture max size <16384>
[INFO              ] [GL          ] Texture max units <16>
[INFO              ] [Window      ] virtual keyboard not allowed, single mode, not docked
[INFO              ] [Text        ] Provider: pygame
 Traceback (most recent call last):
   File "main.py", line 33, in <module>
     from UIElements.screenControls    import   ScreenControls
   File "/Users/johnboiles/Programming/GroundControl/UIElements/screenControls.py", line 7, in <module>
     from UIElements.backgroundMenu                 import   BackgroundMenu
   File "/Users/johnboiles/Programming/GroundControl/UIElements/backgroundMenu.py", line 8, in <module>
     from PIL import Image as PILImage
 ImportError: No module named PIL

Was PIL / Pillow added as dependency recently and possibly this file wasn't updated? Installing Pillow fixes the issue and I'm able to run from source on OSX.

@blurfl
Copy link
Collaborator

blurfl commented Sep 21, 2018

Good suggestion, the requirements_linux.txt probably needs it as well.

@johnboiles
Copy link
Contributor Author

I'll go ahead and add it

@MaslowCommunityGardenRobot
Copy link
Collaborator

Congratulations on the pull request @johnboiles

Now we need to decide as a community if we want to integrate these changes. Vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 48 hours. Ties will not be merged.

I'm just a robot, but I love to see people contributing so I'm going vote thumbs up!

@johnboiles johnboiles changed the title Add Pillow to requirements_osx.txt Add Pillow to requirements_osx.txt and requirements_linux.txt Sep 21, 2018
@MaslowCommunityGardenRobot
Copy link
Collaborator

Time is up and we're ready to merge this pull request. Great work!

@MaslowCommunityGardenRobot MaslowCommunityGardenRobot merged commit 5f4cc4c into MaslowCNC:master Sep 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants