Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make slider work for updating circles #264

Merged
merged 3 commits into from
Oct 3, 2019

Conversation

BarbourSmith
Copy link
Member

@BarbourSmith BarbourSmith commented Oct 3, 2019

Thanks for contributing to Maslow Create! You rock.

Please check that your pull request:

  • Passes lint. You can see which parts of your pull request are not passing lint and fix basic errors by running npm run lint -- --fix from within the Maslow-Create repo

  • Is documented. You can see which lines need to be documented in your pull request by running the command npm run doc from within the Maslow-Create repo and then looking at the generated dist\documentation\coverage.json file.

Thanks for helping to keep the project tidy!

@BarbourSmith
Copy link
Member Author

@alzatin I used the mouseUp event instead of the slider one because I only wanted to update the circles when the slide was finished. Basically the way it works it calls the topLevelMolecule and tells it to update it's circles and to tell any atoms beneath that to update their circles too. I'm not 100% sure it runs in the most efficient way possible, but it's OK for now.

It won't work on atoms imported from github which have no inputs because those are now locked and empty after loading to save memory use. Basically I figured if they have no inputs they are never going to update so I deleted all the stuff inside them after they load the first time to save space. I think that's fine for now too.

@BarbourSmith BarbourSmith merged commit d2e6328 into master Oct 3, 2019
@BarbourSmith BarbourSmith deleted the lock-before-doing-propogation branch October 3, 2019 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant