Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing a list to find([1,2,3]) should return collection #253

Closed
josephmancuso opened this issue Dec 4, 2020 · 0 comments · Fixed by #258
Closed

Passing a list to find([1,2,3]) should return collection #253

josephmancuso opened this issue Dec 4, 2020 · 0 comments · Fixed by #258
Labels
easy These issues are geared for people who have not yet contributed to this project yet enhancement A feature that exists, works as intended but needs to be improved

Comments

@josephmancuso
Copy link
Member 

User.find([1,2,3])

Should be exactly the same as doing:

return self.whereIn(self.get_primary_key(), list).get()
@josephmancuso josephmancuso added enhancement A feature that exists, works as intended but needs to be improved easy These issues are geared for people who have not yet contributed to this project yet labels Dec 4, 2020
@josephmancuso josephmancuso mentioned this issue Dec 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy These issues are geared for people who have not yet contributed to this project yet enhancement A feature that exists, works as intended but needs to be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added ability to pass list to find method MasoniteFramework/orm
1 participant
@josephmancuso