Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add __original_attributes__ to model hydration #301

Closed
josephmancuso opened this issue Jan 7, 2021 · 1 comment · Fixed by #303
Closed

Add __original_attributes__ to model hydration #301

josephmancuso opened this issue Jan 7, 2021 · 1 comment · Fixed by #303
Labels
easy These issues are geared for people who have not yet contributed to this project yet Models These issues relate to the Model portion of the ORM

Comments

@josephmancuso
Copy link
Member

Currently in hydration we hydrate the __attribute__ dictionary. On any changes we hydrate the __dirty_attributes__. What we need to keep track of is the original attributes in a new __original_attributes__ attribute that never changes and is populated with the original data from the hydration of models
@josephmancuso josephmancuso added easy These issues are geared for people who have not yet contributed to this project yet Models These issues relate to the Model portion of the ORM labels Jan 7, 2021
@josephmancuso
Copy link
Member Author

Changes here:

https://github.com/MasoniteFramework/orm/blob/1.0/src/masoniteorm/models/Model.py#L287

and here:

https://github.com/MasoniteFramework/orm/blob/1.0/src/masoniteorm/models/Model.py#L270

@josephmancuso josephmancuso linked a pull request Jan 7, 2021 that will close this issue
added original and dirty methods #303
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy These issues are geared for people who have not yet contributed to this project yet Models These issues relate to the Model portion of the ORM
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added original and dirty methods MasoniteFramework/orm
1 participant
@josephmancuso