Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

group by should act same as order by with column #338

Closed
josephmancuso opened this issue Jan 27, 2021 · 0 comments · Fixed by #342
Closed

group by should act same as order by with column #338

josephmancuso opened this issue Jan 27, 2021 · 0 comments · Fixed by #342
Labels
enhancement A feature that exists, works as intended but needs to be improved medium These issues are geared for people who have contributed to the project before Query Builder Related to the query builder

Comments

@josephmancuso
Copy link
Member

We recently added a way to specify multiple columns in an order by and specify the directions like this:

.order_by("col, col2, col3 desc")

We should be able to do the same with group_bys for consistency:

.group_by("col, col2, col3")
@josephmancuso josephmancuso added medium These issues are geared for people who have contributed to the project before Query Builder Related to the query builder enhancement A feature that exists, works as intended but needs to be improved labels Jan 27, 2021
@josephmancuso josephmancuso mentioned this issue Jan 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A feature that exists, works as intended but needs to be improved medium These issues are geared for people who have contributed to the project before Query Builder Related to the query builder
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added group by fixes MasoniteFramework/orm
1 participant
@josephmancuso