Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error with sqlite importing at the top of the connection class #370

Closed
josephmancuso opened this issue Feb 4, 2021 · 0 comments · Fixed by #374
Closed

Fix error with sqlite importing at the top of the connection class #370

josephmancuso opened this issue Feb 4, 2021 · 0 comments · Fixed by #374
Labels
bug An existing feature is not working as intended

Comments

@josephmancuso
Copy link
Member

Describe the bug
Not all python distributions ship with the sqlite package apparently so when the sqlite package is not installed, This ORM throws sqlite exceptions

To Reproduce
Steps to reproduce the behavior:

  1. Install a python distribution without sqlite installed
  2. Throwing error

Desktop (please complete the following information):

  • OS: Centos

Additional context

  • Fix is in the top of the file in the SQLiteConnection class. This just needs to be lazy loaded like the other connection classes
@josephmancuso josephmancuso added the bug An existing feature is not working as intended label Feb 4, 2021
@josephmancuso josephmancuso mentioned this issue Feb 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An existing feature is not working as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/371 MasoniteFramework/orm
1 participant
@josephmancuso