Query Builder cannot use multiple from_()

[circulon]

Describe the bug
Using multiple table() or from_() only uses the last one defined

To Reproduce

        builder = (
            QueryBuilder()
                .from_('table_a')
                .from_('table_b')
                .select('table_a.col_1 as data_val')
                .where('table_a.col_q', '=', 5)
                .where_column('table_a.table_b_id', 'table_b.id')
        )

Produces

SELECT "table_a"."col_1" AS data_val FROM "table_b" WHERE "table_a"."col_q" = '5' AND "table_a"."table_b_id" = "table_b"."id"

Expected behavior
Expected query is:

SELECT "table_a"."col_1" AS data_val FROM "table_a", "table_b" WHERE "table_a"."col_q" = '5' AND "table_a"."table_b_id" = "table_b"."id"

Desktop (please complete the following information):

• OS: Mac OSX
• Version Catalina 10.15.7

What database are you using?

• Type: Postgres
• Version 10.7
• Masonite ORM v1.0.31

[josephmancuso]

Hmm.. How did i miss this requirement?? It's so obvious lol

[josephmancuso]

This is fixed in version 1.0.32. I tried supporting the

builder = (
    QueryBuilder()
        .from_('table_a')
        .from_('table_b')
        .select('table_a.col_1 as data_val')
        .where('table_a.col_q', '=', 5)
        .where_column('table_a.table_b_id', 'table_b.id')
)

syntax but that was too big of a change and I guess I sorta missed the boat on that one somehow ...

Anyway, the only way to do that now will be to use the new from_raw (or table_raw depending on whatever sounds more semantically right at the time).

So this would look something like this:

builder = (
    QueryBuilder()
        .from_raw('table_a, table_b')
        .select('table_a.col_1 as data_val')
        .where('table_a.col_q', '=', 5)
        .where_column('table_a.table_b_id', 'table_b.id')
)

As a side note, I see you are using the alias in the select method. So small but one of my favorite things lol. :)

[circulon]

@josephmancuso
Thanks for the fix, sorry to hear that its too big as it "reads" nicely in code but yeah the from_raw() will do just fine.

Thanks for investigating and Yes aliased field vaules help immensely when using the query response back into variables/structs of any type for later use. aka super obvious whats going where and why.

Cheers for the continuous improments as well.