with_ relation gives un-wanted data.

[yubarajshrestha]

Describe the bug
When getting relationship result using with_ it gives wrong information about related records.

To Reproduce

1. Create User Model and a Role Model
2. Create another table role_user as a pivot table for user and role for many to many relationship.
3. Now add few records on both.
4. users = User.with_("roles").first()

Current output

{
        "id": 4,
        "code": "USER00004",
        "name": "Admin User",
        "email": "email-id-here",
        "phone": null,
        "status": "active",
        "status_remarks": null,
        "remember_token": null,
        "profile_image": null,
        "verified_at": null,
        "created_at": "2021-07-19T08:55:23+00:00",
        "updated_at": "2021-07-19T08:55:23+00:00",
        "role": {
            "id": 4,
            "name": "Admin",
            "slug": "admin",
            "status": "active",
            "created_at": "2021-07-19T14:28:11.173605+00:00",
            "updated_at": "2021-07-19T14:28:11.173605+00:00",
            "user_id": 4,
            "role_id": 3,
            "pivot": {
                "user_id": 4,
                "role_id": 3,
                "id": 4
            }
        },

Expected output

 {
        "id": 4,
        "code": "USER00004",
        "name": "Admin",
        "email": "email-id-here",
        "phone": null,
        "status": "active",
        "status_remarks": null,
        "remember_token": null,
        "profile_image": null,
        "verified_at": null,
        "created_at": "2021-07-19T08:55:23+00:00",
        "updated_at": "2021-07-19T08:55:23+00:00",
        "role": {
            "id": 3,
            "name": "Admin",
            "slug": "admin",
            "status": "active",
            "created_at": "2021-07-19T14:28:11.173605+00:00",
            "updated_at": "2021-07-19T14:28:11.173605+00:00",
           "pivot": {
                "user_id": 4,
                "role_id": 3,
                "id": 4
            }
        },

DIFF:

{
        "id": 4,
        "code": "USER00004",
        "name": "Admin User",
        "email": "email-id-here",
        "phone": null,
        "status": "active",
        "status_remarks": null,
        "remember_token": null,
        "profile_image": null,
        "verified_at": null,
        "created_at": "2021-07-19T08:55:23+00:00",
        "updated_at": "2021-07-19T08:55:23+00:00",
        "role": {
-             "id": 4,
+            "id": 3
            "name": "Admin",
            "slug": "admin",
            "status": "active",
            "created_at": "2021-07-19T14:28:11.173605+00:00",
            "updated_at": "2021-07-19T14:28:11.173605+00:00",
+            "user_id": 4,
+            "role_id": 3,
             "pivot": {
                "user_id": 4,
                "role_id": 3,
                "id": 4
            }
        },

[Marlysson]

Shouldn't the user_id and role_id attributes returned in 'role' key, right?

[yubarajshrestha]

Shouldn't the user_id and role_id attributes returned in 'role' key, right?

Role key should only contain the record from roles table. user_id and role_id is the part of pivot table i.e; role_user and should not be in role but in role.pivot.

[josephmancuso]

Being fixed in #478

[yubarajshrestha]

Being fixed in #478

Not fixed yet: comment