Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masonite ORM should change '?' to ? in the binding expressions #684

Closed
josephmancuso opened this issue May 24, 2022 · 0 comments · Fixed by #735
Closed

Masonite ORM should change '?' to ? in the binding expressions #684

josephmancuso opened this issue May 24, 2022 · 0 comments · Fixed by #735
Labels
enhancement A feature that exists, works as intended but needs to be improved major This issue can only be done in a major release because there are some breaking changes

Comments

@josephmancuso
Copy link
Member

josephmancuso commented May 24, 2022

One of the smaller odd things with Masonite ORM was the binding syntax. It needed a '?' in the query statements when trying to bind raw statements.

Example:

builder.statement("select count(*) from users where active = '?'", [1])

Notice the quotes around the ? mark. It would be cleaner to be able to just use a ? mark.

Would also need to be done in the grammars as well. And in the connection classes we are replacing this with that the query connection needs

This change would have to be done with Masonite ORM 3 since it would be a breaking change. Can do this issue as we gear up to Masonite 5

https://orm.masoniteproject.com/query-builder#raw-queries

@josephmancuso josephmancuso added the enhancement A feature that exists, works as intended but needs to be improved label May 24, 2022
@josephmancuso josephmancuso added the major This issue can only be done in a major release because there are some breaking changes label Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature that exists, works as intended but needs to be improved major This issue can only be done in a major release because there are some breaking changes
Projects
1 participant