Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is creating migration in order but you are not able to migrate at all. #717

Closed
yubarajshrestha opened this issue Jun 9, 2022 · 2 comments · Fixed by MasoniteFramework/masonite#666

Comments

@yubarajshrestha
Copy link
Contributor

I think this is solve https://github.com/MasoniteFramework/masonite/blob/4.0/src/masonite/packages/providers/PackageProvider.py#L150

Originally posted by @josephmancuso in #626 (comment)

@girardinsamuel
Copy link
Contributor

Can you post the stack trace ? 🙏

@josephmancuso
Copy link
Member

josephmancuso commented Jun 10, 2022

The issue is we added the index to the migration name which is fine and fixes the ordering

but the problem is we were splitting the migration name by 4 _ to get the class name in the ORM.

Since we added an extra _ before and after the index that would cause us to get a migration name like 1CreateUsersTable and we would not be able to locate the class name.

This is fixed in Masonites 717 PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants