BelongsTo relation has wrong amount of QueryBuilder arguments.

[leannextang]

This works at v2.17.2, but fails at v2.18.1.

Steps to reproduce the behavior:

1. Set module Contract:

class Contract(Model):
...
    @belongs_to
    def company(self):
        return models.Company

2. Set module Company:

class Company(Model):
...
    @has_many('id', 'company_id')
    def contract(self):
        return models.Contract
 
    @scope
    def active(self, query):
        return query.where("status", 1)

3. Call models.Contract.with_(('company' :models.Company.active()}).first().uid)

Error Message:

Desktop (please complete the following information):

• OS & FAQ :

Versions:

• Database: Postgres 12.11
• Masonite ORM v2.18.1

[josephmancuso]

models.Contract.with_({"company": models.Company.active()})

This is not the proper usage of this feature. You have to use a lambda expression that takes a query builder instance.

I believe you should be able to do something like:

models.Contract.with_({"company": lambda q: q.active()})

[josephmancuso]

Please see docs here https://orm.masoniteproject.com/models#dynamic-relationships

[leannextang]

Thank you for the information,
we will check how to fix the legacy code here.