Allow for specifying a config path when using ConnectionResolver #863
Labels
enhancement
A feature that exists, works as intended but needs to be improved
feature request
A feature that does not yet exist but will be a good addition to the library
Describe the feature as you'd like to see it
I want to be able to specify a custom config path without setting an extra environment variable.
What do we currently have to do now?
The current implementation of
ConnectionResolver
andConnectionFactory
does the following:ConnectionResolver
initsConnectionFactory
ConnectionFactory
will runmake
, which callsDB = load_config().DB
load_config()
will either use the default config path, or use theDB_CONFIG_PATH
env varAdditional context
The load_config function already has a
config_path
argument. So, my proposal is to:Add an optional
config_path
argument toConnectionResolver
Add an optional
config_path
argument toConnectionFactory
Pass through that
config_path
fromConnectionResolver
to the initialization ofConnectionFactory
Use the
config_path
inload_config
Is this a breaking change?
The text was updated successfully, but these errors were encountered: