fix(lib): fix error patching children of an already replaced element

CHANGELOG.md

@@ -1,9 +1,8 @@
 ### [5.0.12](https://github.com/Masquerade-Circus/valyrian.js/compare/5.0.11...5.0.12) (2021-07-28)
 
-
 ### Code Refactoring
 
-* Refactor 2021 06 14 ([#20](https://github.com/Masquerade-Circus/valyrian.js/issues/20)) ([ceda5ea](https://github.com/Masquerade-Circus/valyrian.js/commit/ceda5ea1f8561983dd3e680a4d9a00e56f3b5292))
+*   Refactor 2021 06 14 ([#20](https://github.com/Masquerade-Circus/valyrian.js/issues/20)) ([ceda5ea](https://github.com/Masquerade-Circus/valyrian.js/commit/ceda5ea1f8561983dd3e680a4d9a00e56f3b5292))
 
 ### [5.0.11](https://github.com/Masquerade-Circus/valyrian.js/compare/5.0.10...5.0.11) (2021-05-01)
 

dist/@types/lib/index.d.ts

@@ -100,8 +100,6 @@ interface Valyrian {
 }
 declare let isNode: boolean;
 declare function createElement(tagName: string, isSVG?: boolean): DomElement;
-declare function domToVnode(dom: DomElement): Vnode & {
-    dom: DomElement;
-};
+declare function domToVnode(dom: DomElement): Vnode;
 declare const trust: (htmlString: string) => Vnode[];
 declare function valyrian(): Valyrian;

lib/index.ts

@@ -124,36 +124,23 @@ function createElement(tagName: string, isSVG: boolean = false): DomElement {
 }
 
 // Transforms a DOM node to a VNode
-function domToVnode(dom: DomElement): Vnode & { dom: DomElement } {
-  const el = dom;
-  const nodeName = el.nodeName.toLowerCase();
-  const props: Props = {};
-  const children: VnodeOrUnknown[] = [];
-  let i: number;
-  let childNode;
-  let attr: Attr;
-
-  // attributes
-  for (i = 0; i < el.attributes.length; i++) {
-    attr = el.attributes[i];
-    props[attr.nodeName] = attr.nodeValue;
-  }
-
-  // children
-  for (i = 0; i < el.childNodes.length; i++) {
-    childNode = el.childNodes[i];
-    if (childNode.nodeType === 1) {
-      children.push(domToVnode(childNode as DomElement));
-    } else if (childNode.nodeType === 3) {
-      let textVnode = new TextVnode(childNode.nodeValue || "");
-      textVnode.dom = childNode as Text;
-      children.push(textVnode);
+function domToVnode(dom: DomElement): Vnode {
+  let props: Props = {};
+  [].forEach.call(dom.attributes, (prop: Attr) => (props[prop.nodeName] = prop.nodeValue));
+
+  let vnode: Vnode = new Vnode(dom.nodeName.toLowerCase(), props, []);
+  vnode.dom = dom;
+
+  for (let i = 0, l = dom.childNodes.length; i < l; i++) {
+    if (dom.childNodes[i].nodeType === 1) {
+      vnode.children.push(domToVnode(dom.childNodes[i] as DomElement));
+    } else if (dom.childNodes[i].nodeType === 3) {
+      let textVnode = new TextVnode(dom.childNodes[i].nodeValue || "");
+      textVnode.dom = dom.childNodes[i] as unknown as Text;
+      vnode.children.push(textVnode);
     }
   }
-
-  let newNode = new Vnode(nodeName, props, children);
-  newNode.dom = dom;
-  return newNode as Vnode & { dom: DomElement };
+  return vnode;
 }
 
 const trust = (htmlString: string) => {
@@ -447,7 +434,7 @@ function valyrian(): Valyrian {
               childVnode.props.oncreate && childVnode.props.oncreate(childVnode);
               oldChildVnode instanceof Vnode && callRemove(oldChildVnode);
               newParentVnode.dom.replaceChild(childVnode.dom, oldChildVnode.dom);
-              patch(childVnode as Vnode & { dom: DomElement }, oldChildVnode);
+              patch(childVnode as Vnode & { dom: DomElement });
             }
           } else {
             if (oldChildVnode instanceof Vnode) {