Extended sender: simulated data

[miguelgarcia]

Hey, this standard is a great initiative. We are exploring it at InOrbit since it seems like a really nice way to get data from different robots into our platform. As part of this exploration we extended the sender to be able to generate more complete status reports with changing data.

Besides this, the PR includes a couple of fixes/improvements that we believe are useful:

• Fixed missing import of datetime timezone
• Read URI from argv

Thanks !

[miguelgarcia]

Hi @cacioppoc @zac-dydek is creating a PR the best way to contribute to this repo or is there another preferred method ?

Thanks a lot, have a great week!

[zac-dydek]

These are great additions, just one small change to make the operational state choices match the standard document.

[zac-dydek]

The operational states in our working document are similar, but not identical. We split "waiting" into:

1. Waiting for human event (which probably covers your "loadingUnloading" state?)
2. Waiting for external event
3. Waiting for internal event

[miguelgarcia]

Hi @zac-dydek I copied these values from /AMR_Interop_Standard.json, which seems to don't exactly follow what's in the doc. I can piggyback that change into this PR. What do you think would be good names ?

1. waitingHumanEvent
2. waitingExternalEvent
3. waitingInternalEvent
   ??

Thanks!

[zac-dydek]

I see, yes, it seems the .json file is slightly out-of-date. Yes, let's make that change while we're at it. The names you picked are fine with me!

[miguelgarcia]

Thanks @zac-dydek I made the changes, could you review ?

Thanks!

[zac-dydek]

Looks great, thanks!