Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uses should bind json instead of bind json #7

Closed
wants to merge 1 commit into from

Conversation

h4ck3rk3y
Copy link

hey!

great template! I saw your comment with //406 and I couldn't help but wonder why.

This doc suggests that bindJSON automatically sets it to 400 and then does an abort so when you set code to 406 that doesn't do anything.

@h4ck3rk3y h4ck3rk3y requested a review from Massad February 7, 2020 21:25
Copy link
Owner

@Massad Massad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Thank you for the change, you are correct and I reflected the changes.

@Massad Massad closed this May 9, 2020
Massad added a commit that referenced this pull request May 9, 2020
Massad added a commit that referenced this pull request May 9, 2020
Massad added a commit that referenced this pull request May 9, 2020
Massad added a commit that referenced this pull request May 9, 2020
@Massad Massad self-assigned this Jun 10, 2021
@Massad Massad added the bug label Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants