Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

54 facade shedule #61

Merged
merged 3 commits into from
Dec 24, 2022
Merged

54 facade shedule #61

merged 3 commits into from
Dec 24, 2022

Conversation

Theo-Hafsaoui
Copy link
Member

@Theo-Hafsaoui Theo-Hafsaoui commented Dec 22, 2022 •
edited
Loading

PR to implement the facade shedule
#54

.
├── main
│   ├── java
│   │   └── fr
│   │       └── univtln
│   │           └── lhd
│   │               ├── controllers
│   │               ├── exceptions
│   │               ├── facade
│   │               │   └── Schedule.java
│   │               ├── model
│   │               │   └── entities
│   │               │       ├── dao
│   │               │       │   ├── ...
│   │               │       │   ├── slots
│   │               │       │   │   └── ....
│   │               │       │   └── users
│   │               │       │       ├── ....
│   │               │       ├── slots
│   │               │       │   ├── ....
│   │               │       └── users
│   │               │           ├── ....
│   │               └── view
│   │                   ├── ....
  • GetSchedule(Student)
  • GetSchedule(Group)
  • Test

@Theo-Hafsaoui Theo-Hafsaoui linked an issue Dec 22, 2022 that may be closed by this pull request
Facade Shedule #54
Closed
@Theo-Hafsaoui Theo-Hafsaoui self-assigned this Dec 23, 2022
@Theo-Hafsaoui Theo-Hafsaoui added the enhancement New feature or request label Dec 23, 2022
@Theo-Hafsaoui
Add facade Schedule with his getter for US1
7cf9c80 
Package facade created, with his new class "Schedule.java"
it is compose of only one getter for the first US. this getter has some
overloading with Student/Group and variattion for the timerange
between Interval(Database) and LocalDate(JavaFx datepicker)
the test need to be made more riogorous when the dao is updated
@Theo-Hafsaoui Theo-Hafsaoui marked this pull request as ready for review December 23, 2022 13:48
@Desmondmies Desmondmies mentioned this pull request Dec 23, 2022
Closed
anastygnome
anastygnome requested changes Dec 24, 2022
View reviewed changes
Copy link
Contributor

@anastygnome anastygnome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though a few things need to be addressed

edtLHD/src/edittree Outdated Show resolved Hide resolved
edtLHD/src/main/java/fr/univtln/lhd/facade/Schedule.java Show resolved Hide resolved
edtLHD/src/main/java/fr/univtln/lhd/facade/Schedule.java Outdated Show resolved Hide resolved
edtLHD/src/test/java/fr/univtln/lhd/facade/ScheduleTest.java Outdated Show resolved Hide resolved
@Theo-Hafsaoui Theo-Hafsaoui merged commit 4c84a07 into develop Dec 24, 2022
@Theo-Hafsaoui Theo-Hafsaoui deleted the 54-facade-shedule branch December 24, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anastygnome anastygnome anastygnome approved these changes

@Desmondmies Desmondmies Desmondmies approved these changes

Assignees

@Theo-Hafsaoui Theo-Hafsaoui

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Facade Shedule
3 participants
@Theo-Hafsaoui @anastygnome @Desmondmies