Controller Edt interfacing with Schedule Facade #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Not a great idead to start from PR, it might cause issue into the future |
|
i wasn't sure how to do, merging to your facade branch seemed to be the easiest way for me to continue working upon Schedule Facade without waiting merge into develop |
|
I know and understand, that the main issue with our workflow. It's slow. But it would be hypocrite of me not to say anything to you when I am quite harsh with @anastygnome |
Theo-Hafsaoui
force-pushed
the
54-facade-shedule
branch
2 times, most recently
from
d8c8b20
to
4c84a07
Compare
Closed
|
@Desmondmies do you need help to fix the conflicts? |
|
Current interface look Quick summary :
|
Theo-Hafsaoui
approved these changes
Dec 27, 2022
Link Controller / Facade (now displays weekly schedule for a student)
Add Weeks Support & Controls
Polish / Recolor interface
anastygnome
force-pushed
the
64-controller-edt
branch
from
f48970e
to
c17d3e6
Compare
anastygnome
pushed a commit
that referenced
this pull request
Dec 27, 2022
Link Controller / Facade (now displays weekly schedule for a student)
Add Weeks Support & Controls
Polish / Recolor interface
anastygnome
pushed a commit
that referenced
this pull request
Jan 25, 2023
Link Controller / Facade (now displays weekly schedule for a student)
Add Weeks Support & Controls
Polish / Recolor interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
controller implemention using Facade and Observer Pattern