Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve an Issue - Best Practice #27

Closed
guilyx opened this issue Jun 1, 2020 · 0 comments
Closed

Solve an Issue - Best Practice #27

guilyx opened this issue Jun 1, 2020 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@guilyx
Copy link
Member

guilyx commented Jun 1, 2020

How to [current practice]

  1. git clone https://github.com/master-coro/rtros-documentation.git
  2. git checkout master
  3. git pull
  4. git checkout -b issue-x OR git branch issue-x && git checkout issue-x with x being the number of the issue
  5. Add & Commit your changes
  6. git push -u origin issue-x
  7. Go to https://github.com/master-coro/rtros-documentation/pull/new/issue-x to open the PR

How to [better than our current practice]

  1. Fork the project
  2. Clone your fork
  3. Follow the first chapter starting point no 2

What could I do wrong

  • You didn't pull before changing the current branch
  • You pulled a deprecated/late branch
  • ...

How do I fix it

  1. Copy what you did
  2. git checkout master && git pull
  3. git branch issue-x && git checkout issue-x
  4. Paste what you did
  5. Follow the first chapter starting poit no 5
@guilyx guilyx added documentation Improvements or additions to documentation good first issue Good for newcomers labels Jun 1, 2020
@guilyx guilyx pinned this issue Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants