feat/json-type-updates #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterKale
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just went through all the types
JSONtypes in @simplewebauthn/typescript-types and matched them against the latest L3 draft and almost everything looks good:...Except for missing additions of the "convenience values"
publicKeyAlgorithm,publicKey, andauthenticatorDataonAuthenticatorAttestationResponseJSON. These values come from the correspondingly-namedget...()methods onAuthenticatorAttestationResponse.The types deviate a bit from what's in L3 because 1) L3 isn't the Recommendation yet, and 2) browser compatibility is still a little spotty (MDN says Firefox doesn't really support the getters):
getAuthenticatorData()getPublicKeyAlgorithm()getPublicKey()This PR will return the values in the output from browser's
startRegistration()when their corresponding getter methods are available.Fixes #384.