feature/enhance-rsa-support #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue #49 prompted me to finally push up my initial work at tracking down this bug. |
Thanks to https://github.com/abergs/fido2-net-lib/ for their legitimate TPM responses.
This should be what actually fixes the ASN.1 tag issue I was trying to fix. This might be a breaking change…
I wrote a simple script to convert existing “old format” authenticator public keys to a newer format.
MasterKale
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances support for attestations and assertions containing RSA authenticator public keys. The simple fact is too much code assumed it was handling EC2 public keys; going RSA public key was surprisingly underbaked.
I've renamed the PR to reflect the fact that it wasn't TPM attestation support that was fixed, but rather attestations containing RSA public keys, of which TPM devices commonly produce.
This PR contains a breaking change! The entire authenticator public key is now returned from
verifyAttestationResponse()instead of a previously pared down amount of public key info. Any authenticator public keys stored before this PR are no longer valid for use in assertions.Fortunately I was able to create a simple "upgrade" script that these "old" public keys can be run through to fix them:
https://gist.github.com/MasterKale/175cb210b097632d7cd03fd409e2dfb3