Fixes Issue #9 #13
Open
Fixes Issue #9 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
resolve conflicts? |
|
Looks like this causes an infinite hang on my machine on your text example in both 2.7 and 3.7. Will try and play around more with this and figure out what's going on and why it worked 2 years ago and not now. |
foozzi
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #9 shows that ANSI escape sequences aren't detected when coloring strings, which leads to a
ColorStringformatted with anotherColorStringto lose its color information at the end. This fix finds any ANSI escape sequences usingreand works around them.As a test case: