Fix whatsapp parsing #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes. The format (not just time but also special chars) of the datetime part before the username can differ from export to export. Further multiline messages can have a date and/or time at the beginning of a line. Therefore, the pattern is determined before the actual parsing. |
|
Resolved by #46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
infer_datetime_regexwithingwhatsapp.pyhandles single digit month day values in the whatsapp timestamp incorrectly. Causing the parser to ignore a huge amount of messages. This error depends on the first time value encountered.I'm not quite sure why the regex isn't a constant, but this pull request should fix the problem while maintaining the flexibility of the original function.
Before:
After: