Fix CustomRemoveAll() to handle spaces in paths, and also file not found. #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Windows fix had a few bugs in it, specifically it would throw an error if there was a space in the path. In addition, deleting a non-existent directory or file, which are not errors under *nix when using rm, were generating errors on Windows.
|
@jpz thanks for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to problem mentioned in #905
This deals with two related implementation details in winbug.go -
the function was not working successfully, because it was not enquoting the path with spaces correctly.
the exit code from Windows RD command (remove directory) should be be handled - "directory not found" should not really be an error. By analogy,
rm -rfreturns no error code for a non-existent file.I've tested this several times manually, but nice to get other checks on it.