Fixed tests on Windows: changed "\n" -> PHP_EOL #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New lines are represented by "\r\n" characters on Windows so tests relying on "\n" are failing.
|
Yeah, this should definitely be done. It passes for me on UNIX, so we should be good. Merging now. |
technosophos
added a commit
that referenced
this pull request
Feb 11, 2014
Fixed tests on Windows: changed "\n" -> PHP_EOL
|
I also added @miso-belica to the CREDITS file. Feel free to change any info in there. It follows the PHP standard format, and I put in a fake email address. If you want your real one, just send me a pull request. |
|
Thanks a lot :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New lines are represented by "\r\n" characters on Windows so tests relying on "\n" are failing.