Fixed infinite loop for char "&" in unquoted attribute #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, updating of composer failed. But I tested it on PHP v5.4.16 so probably it's fine on 5.4 version :) |
|
@miso-belica thanks for catching this. I re-ran the test and it passed. I'd like @technosophos to take a look at this. |
technosophos
added a commit
that referenced
this pull request
Feb 11, 2014
Fixed infinite loop for char "&" in unquoted attribute
|
Yup, I agree with this patch. I'm merging it. Thanks, @miso-belica |
|
@miso-belica Just wanted to let you know -- I liked the way you presented the issue here very much, and I'm using this issue as an example to my CompSci students for how to contribute to someone's project. Thanks again. |
|
Yeeeeeee, I will be famous :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that my server was overloaded by Apache's threads because of infinite loops in this library. Reproducible example:
And file
test.htmlThere are more pages that is causing overload of my server so I checked some of them and noticed it is caused by character ampersand (no matter if it's valid entity or not) in unquoted attribute. It's possible that some another infinite loop in library exists, but I can't check all of the pages. If I discover another one infinite loop I create an issue at least :)