Parse RCDATA the right way #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for sending this over! While it looks simple, I started to walk through everything and may have found a bug (outside your code). I'll get through this in the next few days. |
|
Thanks for reporting current status. Ok, I will wait for you. Please feel free to tell me if it will be found that I will need fix my patch. |
|
@KitaitiMakoto Thank you very much for this patch. Simple, clean, and elegant. My feeling is that we should merge this one and then fix the other bug separately. |
technosophos
added a commit
that referenced
this pull request
May 30, 2014
|
Glad to precious words. Thanks merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #40